Skip region validation in S3BlobStoreRepositoryTests
#127372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today these tests assert that the requests received by the handler are signed in region `us-east-1` with no region specified, but in fact when running in EC2 the SDK will pick up the actual region which may be different. This commit skips this region validation for now (it is tested elsewhere).
DaveCTurner
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
DaveCTurner
added
auto-backport
pxsalehi
approved these changes
Apr 25, 2025
DaveCTurner
deleted the
2025/04/25/S3BlobStoreRepositoryTests-skip-region-validation
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 25, 2025
Today these tests assert that the requests received by the handler are signed in region `us-east-1` with no region specified, but in fact when running in EC2 the SDK will pick up the actual region which may be different. This commit skips this region validation for now (it is tested elsewhere).
Collaborator
💚 Backport successful
|
nicktindall
pushed a commit
to nicktindall/elasticsearch
that referenced
this pull request
Apr 28, 2025
Today these tests assert that the requests received by the handler are signed in region `us-east-1` with no region specified, but in fact when running in EC2 the SDK will pick up the actual region which may be different. This commit skips this region validation for now (it is tested elsewhere). (cherry picked from commit 15b6e85)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 28, 2025
…7381) Today these tests assert that the requests received by the handler are signed in region `us-east-1` with no region specified, but in fact when running in EC2 the SDK will pick up the actual region which may be different. This commit skips this region validation for now (it is tested elsewhere). Co-authored-by: Nick Tindall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today these tests assert that the requests received by the handler are
signed in region
us-east-1with no region specified, but in fact whenrunning in EC2 the SDK will pick up the actual region which may be
different. This commit skips this region validation for now (it is
tested elsewhere).
Closes #127360
Closes #127361
Closes #127362
Closes #127363
Closes #127364
Closes #127366
Closes #127367
Closes #127373
Closes #127374
Closes #127376
Closes #127377